Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade expo to 51.0.11 #1652

Merged
merged 23 commits into from
Jun 10, 2024
Merged

Upgrade expo to 51.0.11 #1652

merged 23 commits into from
Jun 10, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented Mar 6, 2024

No description provided.

@mshima mshima force-pushed the expo-50 branch 4 times, most recently from ae6b580 to 82469ee Compare June 6, 2024 12:14
@mshima mshima changed the title Bump expo 50.0.8 Bump expo 51.0.10 Jun 6, 2024
@mraible mraible mentioned this pull request Jun 8, 2024
1 task
.github/workflows/app.yml Outdated Show resolved Hide resolved
@mraible
Copy link
Contributor

mraible commented Jun 8, 2024

Currently, if you navigate to list screens in the web, you'll get an error that you cannot access the fetch method before its been initialized. This does not happen in iOS.

Screenshot 2024-06-08 at 1 20 37 PM

You can fix this by moving the fetch method's definition above useFocusEffect(). However, after you do that, you still can't edit an item.

Screenshot 2024-06-08 at 1 21 25 PM

@mraible
Copy link
Contributor

mraible commented Jun 9, 2024

I generated a new app with the main branch to see if the list and edit screen issues exist there. The setimmediate issue does exist, the list screen works, and the same error happens on the edit screen.

@mraible
Copy link
Contributor

mraible commented Jun 9, 2024

I tried with the last published version (v4.4.0 with Node 16). In web, the entities list works, but when you try to view any of the entities, it fails:

&platform=web&dev=true&hot=false&lazy=true:157128 Warning: React.jsx: type is invalid -- 
  expected a string (for built-in components) or a class/function (for composite components) but got: undefined. 
  You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `Header`.

@mraible
Copy link
Contributor

mraible commented Jun 10, 2024

I think we should merge this. The edit screens don't work in a browser. They do work in iOS and Android. Edit screens don't work on main currently or in the last release, so it doesn't break anything.

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ and removed $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ labels Jun 10, 2024
@mraible mraible changed the title Bump expo 51.0.10 Upgrade expo to 51.0.11 Jun 10, 2024
@mraible mraible marked this pull request as ready for review June 10, 2024 04:13
@mraible mraible enabled auto-merge (squash) June 10, 2024 04:15
@mraible mraible merged commit 1f8272d into jhipster:main Jun 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants