Merge pull request #16027 from qmonmert/react/sonar

[React] Sonar: Extract this nested ternary operation into an independent statement
jhipster · Aug 22, 2021 · 73ed7da · 73ed7da
2 parents 07ebaca + d700de4
commit 73ed7da
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...s/client/templates/react/src/main/webapp/app/modules/administration/health/health.tsx.ejs b/...s/client/templates/react/src/main/webapp/app/modules/administration/health/health.tsx.ejs
@@ -48,6 +48,8 @@ export const HealthPage = () => {
     setHealthObject({ ...healthObj, name });
   };
 
+  const getBadgeType = (status: string) => status !== 'UP' ? 'danger' : 'success';
+
   const handleClose = () => setShowModal(false);
 
   const renderModal = () => <HealthModal healthObject={healthObject} handleClose={handleClose} showModal={showModal} />;
@@ -84,7 +86,7 @@ export const HealthPage = () => {
                   <tr key={configPropIndex}>
                     <td>{configPropKey}</td>
                     <td>
-                      <Badge color={data[configPropKey].status !== 'UP' ? 'danger' : 'success'}>{data[configPropKey].status}</Badge>
+                      <Badge color={getBadgeType(data[configPropKey].status)}>{data[configPropKey].status}</Badge>
                     </td>
                     <td>
                       {data[configPropKey].details ? (