Merge pull request #26936 from mshima/eslint

add more eslint rules to base
jhipster · Aug 9, 2024 · 7af9a9d · 7af9a9d
2 parents ecad4e7 + ec1b0ae
commit 7af9a9d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -78,17 +78,13 @@ export default ts.config(
   },
   {
     rules: {
-      'eol-last': 'error',
-      quotes: ['error', 'single', { avoidEscape: true }],
-      semi: ['error', 'always'],
       eqeqeq: ['error', 'smart'],
       'no-use-before-define': ['error', 'nofunc'],
       'no-multi-str': 'error',
       'no-irregular-whitespace': 'error',
       'no-console': 'error',
       'no-template-curly-in-string': 'error',
       'no-nested-ternary': 'error',
-      'lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],
       'no-restricted-syntax': [
         'error',
         {

diff --git a/generators/angular/templates/src/main/webapp/app/core/util/data-util.service.ts.ejs b/generators/angular/templates/src/main/webapp/app/core/util/data-util.service.ts.ejs
@@ -89,7 +89,7 @@ export class DataUtils {
           };
           observer.error(error);
         } else {
-          const fieldContentType: string = field + 'ContentType';
+          const fieldContentType = field + 'ContentType';
           this.toBase64(file, (base64Data: string) => {
             editForm.patchValue({
               [field]: base64Data,

diff --git a/lib/eslint/base.js b/lib/eslint/base.js
@@ -14,6 +14,19 @@ const baseConfig = {
     import: fixupPluginRules(imports),
   },
   rules: {
+    'dot-notation': 'error',
+    eqeqeq: ['error', 'always', { null: 'ignore' }],
+    'no-else-return': 'error',
+    'no-regex-spaces': 'error',
+    'no-useless-computed-key': 'error',
+    'no-useless-return': 'error',
+    'no-var': 'error',
+    'object-shorthand': 'error',
+    'prefer-const': 'error',
+    'prefer-destructuring': ['error', { array: false }],
+    'prefer-object-has-own': 'error',
+    'prefer-object-spread': 'error',
+    'prefer-template': 'error',
     'sort-imports': ['error', { ignoreDeclarationSort: true }],
 
     // Configure unused-imports rule