Merge pull request #23766 from mshima/skip_ci-session

allow /login to be accesed directly at session auth
jhipster · Oct 7, 2023 · 7cfaf0e · 7cfaf0e
2 parents 8689b26 + 7f478b7
commit 7cfaf0e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs
@@ -40,6 +40,13 @@ describe('login modal', () => {
   it('greets with signin', () => {
     cy.get(titleLoginSelector).should('be.visible');
   });
+<%_ if (clientFrameworkAngular) { _%>
+
+  it('greets visiting /login directly', () => {
+    cy.visit('/login');
+    cy.get(titleLoginSelector).should('be.visible');
+  });
+<%_ } _%>
 
   it('requires username', () => {
     cy.get(passwordLoginSelector).type('a-password');

diff --git a/...server/templates/src/main/java/_package_/config/SecurityConfiguration_imperative.java.ejs b/...server/templates/src/main/java/_package_/config/SecurityConfiguration_imperative.java.ejs
@@ -245,6 +245,7 @@ public class SecurityConfiguration {
             )
             .formLogin(formLogin ->
                 formLogin
+                    .loginPage("/")
                     .loginProcessingUrl("/api/authentication")
                     .successHandler((request, response, authentication) -> response.setStatus(HttpStatus.OK.value()))
                     .failureHandler((request, response, exception) -> response.setStatus(HttpStatus.UNAUTHORIZED.value()))

diff --git a/...s/server/templates/src/main/java/_package_/config/SecurityConfiguration_reactive.java.ejs b/...s/server/templates/src/main/java/_package_/config/SecurityConfiguration_reactive.java.ejs
@@ -244,6 +244,7 @@ public class SecurityConfiguration {
 <%_ } _%>
 <%_ if (authenticationTypeSession) { _%>
             .formLogin(formLogin -> formLogin
+                .loginPage("/")
                 .requiresAuthenticationMatcher(pathMatchers(HttpMethod.POST, "/api/authentication"))
                 .authenticationEntryPoint(new HttpStatusServerEntryPoint(HttpStatus.OK))
                 .authenticationSuccessHandler(this::onAuthenticationSuccess)