Merge pull request #26316 from qmonmert/cypresswarn

Cypress: Fix warn 'response is possibly undefined'
jhipster · May 30, 2024 · ca0bdea · ca0bdea
2 parents f360fb3 + 441329a
commit ca0bdea
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 18 deletions.
diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/login-page.cy.ts.ejs
@@ -52,7 +52,7 @@ describe('login modal', () => {
     cy.get(passwordLoginSelector).type('a-password');
     cy.get(submitLoginSelector).click();
 <%_ if (!clientFrameworkReact) { _%>
-    cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>));
+    cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>));
 <%_ } _%>
     // login page should stay open when login fails
     cy.get(titleLoginSelector).should('be.visible');
@@ -62,7 +62,7 @@ describe('login modal', () => {
     cy.get(usernameLoginSelector).type('a-login');
     cy.get(submitLoginSelector).click();
 <%_ if (!clientFrameworkReact) { _%>
-    cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>));
+    cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(<% if (authenticationTypeSession) { %>401<% } else { %>400<% } %>));
     cy.get(errorLoginSelector).should('be.visible');
 <%_ } else { _%>
     // login page should stay open when login fails
@@ -74,15 +74,15 @@ describe('login modal', () => {
     cy.get(usernameLoginSelector).type(username);
     cy.get(passwordLoginSelector).type('bad-password');
     cy.get(submitLoginSelector).click();
-    cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(401));
+    cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(401));
     cy.get(errorLoginSelector).should('be.visible');
   });
 
   it('go to login page when successfully logs in', () => {
     cy.get(usernameLoginSelector).type(username);
     cy.get(passwordLoginSelector).type(password);
     cy.get(submitLoginSelector).click();
-    cy.wait('@authenticate').then(({ response }) => expect(response.statusCode).to.equal(200));
+    cy.wait('@authenticate').then(({ response }) => expect(response?.statusCode).to.equal(200));
     cy.hash().should('eq', '');
   });
 });
diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/password-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/password-page.cy.ts.ejs
@@ -80,14 +80,14 @@ describe('/account/password', () => {
     cy.get(newPasswordSelector).type('jhipster');
     cy.get(confirmPasswordSelector).type('jhipster');
     cy.get(submitPasswordSelector).click();
-    cy.wait('@passwordSave').then(({ response }) => expect(response.statusCode).to.equal(400));
+    cy.wait('@passwordSave').then(({ response }) => expect(response?.statusCode).to.equal(400));
   });
 
   it("should be able to update password", () => {
     cy.get(currentPasswordSelector).type(password);
     cy.get(newPasswordSelector).type(password);
     cy.get(confirmPasswordSelector).type(password);
     cy.get(submitPasswordSelector).click();
-    cy.wait('@passwordSave').then(({ response }) => expect(response.statusCode).to.equal(200));
+    cy.wait('@passwordSave').then(({ response }) => expect(response?.statusCode).to.equal(200));
   });
 });
diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/account/register-page.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/account/register-page.cy.ts.ejs
@@ -128,6 +128,6 @@ describe('<%= registerPage %>', () => {
     cy.get(firstPasswordRegisterSelector).type('jondoe');
     cy.get(secondPasswordRegisterSelector).type('jondoe');
     cy.get(submitRegisterSelector).click();
-    cy.wait('@registerSave').then(({ response }) => expect(response.statusCode).to.equal(201));
+    cy.wait('@registerSave').then(({ response }) => expect(response?.statusCode).to.equal(201));
   });
 });
diff --git a/...s/cypress/templates/src/test/javascript/cypress/e2e/account/reset-password-page.cy.ts.ejs b/...s/cypress/templates/src/test/javascript/cypress/e2e/account/reset-password-page.cy.ts.ejs
@@ -54,6 +54,6 @@ describe('forgot your password', () => {
   it('should be able to init reset password', () => {
     cy.get(emailResetPasswordSelector).type('user@gmail.com');
     cy.get(submitInitResetPasswordSelector).click({ force: true });
-    cy.wait('@initResetPassword').then(({ response }) => expect(response.statusCode).to.equal(200));
+    cy.wait('@initResetPassword').then(({ response }) => expect(response?.statusCode).to.equal(200));
   });
 });
diff --git a/generators/cypress/templates/src/test/javascript/cypress/e2e/entity/_entity_.cy.ts.ejs b/generators/cypress/templates/src/test/javascript/cypress/e2e/entity/_entity_.cy.ts.ejs
@@ -146,7 +146,7 @@ describe('<%= entityClass %> e2e test', () => {
     cy.visit('/');
     cy.clickOnEntityMenuItem('<%= entityPage %>');
     cy.wait('@entitiesRequest').then(({ response }) => {
-      if (response.body.length === 0) {
+      if (response?.body.length === 0) {
         cy.get(entityTableSelector).should('not.exist');
       } else {
         cy.get(entityTableSelector).should('exist');
@@ -171,7 +171,7 @@ describe('<%= entityClass %> e2e test', () => {
         cy.get(entityCreateSaveButtonSelector).should('exist');
         cy.get(entityCreateCancelButtonSelector).click();
         cy.wait('@entitiesRequest').then(({ response }) => {
-          expect(response.statusCode).to.equal(200);
+          expect(response?.statusCode).to.equal(200);
         });
         cy.url().should('match', <%= entityInstance %>PageUrlPattern);
       });
@@ -232,7 +232,7 @@ describe('<%= entityClass %> e2e test', () => {
         cy.visit(<%= entityInstance %>PageUrl);
 
         cy.wait('@entitiesRequest').then(({ response }) => {
-          if (response.body.length === 0) {
+          if (response?.body.length === 0) {
             this.skip();
           }
         });
@@ -244,7 +244,7 @@ describe('<%= entityClass %> e2e test', () => {
         cy.getEntityDetailsHeading('<%= entityInstance %>');
         cy.get(entityDetailsBackButtonSelector).click();
         cy.wait('@entitiesRequest').then(({ response }) => {
-          expect(response.statusCode).to.equal(200);
+          expect(response?.statusCode).to.equal(200);
         });
         cy.url().should('match', <%= entityInstance %>PageUrlPattern);
       });
@@ -256,7 +256,7 @@ describe('<%= entityClass %> e2e test', () => {
         cy.get(entityCreateSaveButtonSelector).should('exist');
         cy.get(entityCreateCancelButtonSelector).click();
         cy.wait('@entitiesRequest').then(({ response }) => {
-          expect(response.statusCode).to.equal(200);
+          expect(response?.statusCode).to.equal(200);
         });
         cy.url().should('match', <%= entityInstance %>PageUrlPattern);
       });
@@ -266,7 +266,7 @@ describe('<%= entityClass %> e2e test', () => {
         cy.getEntityCreateUpdateHeading('<%= entityClass %>');
         cy.get(entityCreateSaveButtonSelector).click();
         cy.wait('@entitiesRequest').then(({ response }) => {
-          expect(response.statusCode).to.equal(200);
+          expect(response?.statusCode).to.equal(200);
         });
         cy.url().should('match', <%= entityInstance %>PageUrlPattern);
       });
@@ -284,10 +284,10 @@ describe('<%= entityClass %> e2e test', () => {
         cy.getEntityDeleteDialogHeading('<%= entityInstance %>').should('exist');
         cy.get(entityConfirmDeleteButtonSelector).click();
         cy.wait('@deleteEntityRequest').then(({ response }) => {
-          expect(response.statusCode).to.equal(204);
+          expect(response?.statusCode).to.equal(204);
         });
         cy.wait('@entitiesRequest').then(({ response }) => {
-          expect(response.statusCode).to.equal(200);
+          expect(response?.statusCode).to.equal(200);
         });
         cy.url().should('match', <%= entityInstance %>PageUrlPattern);
   <% if (cypressBootstrapEntities) { %>
@@ -351,11 +351,11 @@ describe('<%= entityClass %> e2e test', () => {
       cy.get(entityCreateSaveButtonSelector).click();
 
       cy.wait('@postEntityRequest').then(({ response }) => {
-        expect(response.statusCode).to.equal(201);
+        expect(response?.statusCode).to.equal(201);
         <%= entityInstance %> = response.body;
       });
       cy.wait('@entitiesRequest').then(({ response }) => {
-        expect(response.statusCode).to.equal(200);
+        expect(response?.statusCode).to.equal(200);
       });
       cy.url().should('match', <%= entityInstance %>PageUrlPattern);
     });