-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add id to PUT requests. #14251
Add id to PUT requests. #14251
Conversation
@pascalgrimaud do you think we should keep backward compatibility with PUT without id? |
@mshima : IMO, no need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the change in gatling tests
🤔 there are no PUT tests in Gatling. |
Oh my bad, so forget my comment ahaha |
@pascalgrimaud no problem I will try to add. |
I don't think it is needed as @atomfrede is working on gatling. My comment was to not forget this part in case of it is used. |
Closes #14139.
This PR changes PUT requests to require id in the Url to match GET requests.
Following discussions of HTTP specification.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.