[Vue] Remove condition to import bootstrap-variables in vendor.scss

[qmonmert]

Fix #14294

With Angular, we always do @import 'bootstrap-variables'; on vendor.scss

generator-jhipster/generators/client/templates/angular/src/main/webapp/content/scss/vendor.scss.ejs

Line 29 in 7728837

@import 'bootstrap-variables';

but not with Vue (there is a condition). I don't know why 00c1a2e#diff-91bb2f362ad6ae20a3d2f82daaf5cc7e0f76d3e1c7c1e3b525c56e396d0007b1

---

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• jhipster-online was updated if necessary
• Documentation is added/updated where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[pascalgrimaud]

@qmonmert : not sure about this change. I generated an application with the theme, and it's broken. The theme is not used at all:

If I revert this change, the app looks like:

[qmonmert]

@pascalgrimaud strange because in Angularwe have that

generator-jhipster/generators/client/templates/angular/src/main/webapp/content/scss/vendor.scss.ejs

Line 29 in 7728837

@import 'bootstrap-variables';

[pascalgrimaud]

It has been long time, I didn't generate angular app. Vue is my default config.
I need to give a try and compare

[pascalgrimaud]

With Angular it's better:

So, it means the order is not correct for Vue

[vishal423]

In vue, you need to add a conditional check to not provide custom styles in this scenario. Like below angular:

https://github.com/qmonmert/generator-jhipster/blob/51bd76a372a077885ae6290c67d1dd3e84912983/generators/client/templates/angular/src/main/webapp/content/scss/_bootstrap-variables.scss.ejs#L26