Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Upgrade react-jhipster 0.15.0 #14392

Merged
merged 1 commit into from
Mar 20, 2021
Merged

[React] Upgrade react-jhipster 0.15.0 #14392

merged 1 commit into from
Mar 20, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Mar 20, 2021

Fix #14390

cc @pascalgrimaud @gzsombor @deepu105

cause

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom id should be passed?

@qmonmert
Copy link
Contributor Author

@mshima your suggests don't work

image

@mshima
Copy link
Member

mshima commented Mar 20, 2021

@qmonmert my bad. user-management.tsx.ejs should be user.primaryKey.name instead.

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Mar 20, 2021
@pascalgrimaud
Copy link
Member

Adding a bounty as the fix was needed quickly for the release v7
Thanks and don't forget to claim it @qmonmert

@pascalgrimaud pascalgrimaud merged commit cff779c into jhipster:main Mar 20, 2021
@qmonmert
Copy link
Contributor Author

thanks @pascalgrimaud ;)

@qmonmert
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

@qmonmert : approved ! thanks again for the help!

@pascalgrimaud pascalgrimaud added this to the v7.0.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants