-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail to get jwt token #14443
Fail to get jwt token #14443
Conversation
Gitea seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@hwqllang thanks for your PR. We need to check if |
@hwqllang can you explain why token parsing is required in swagger-ui? Personally, I don't understand it because next line is using it in header as bearer token so I would think that base64 encoding is expected. |
I think there is indeed a bug in your current 7.0.0, but it needs to be confirmed:
This PR seems to fix the issue for Angular and React, but it won't work for Vue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pascalgrimaud the problem seems to be that ngx-webstorage stores it encoded.
At this page we use bare localStorage.
Not sure we can fix it another way.
generators/client/templates/common/src/main/webapp/swagger-ui/index.html.ejs
Outdated
Show resolved
Hide resolved
@hwqllang can you fix the user of the first commit? |
@mshima sorry for that, the user of the first commit is wrong, it is default user of my server, and I don't know how to fix it. |
@hwqllang thanks and congrats for your first contribution. |
Tested with angular/react and remember me enabled/disabled. |
@hwqllang : it's an important bug so I added a bounty on this. Don't forget to claim it |
Bounty claimed - https://opencollective.com/generator-jhipster/expenses/37328 |
@hwqllang : approved and thanks for your fix |
Fix #14488
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.