Add support to unidirectional relationships. #14461
Conversation
jdl/converters/jdl-to-json/jdl-to-json-relationship-converter.js
Outdated
Show resolved
Hide resolved
jdl/converters/jdl-to-json/jdl-to-json-relationship-converter.js
Outdated
Show resolved
Hide resolved
jdl/converters/jdl-to-json/jdl-to-json-relationship-converter.js
Outdated
Show resolved
Hide resolved
jdl/converters/jdl-to-json/jdl-to-json-relationship-converter.js
Outdated
Show resolved
Hide resolved
| @@ -108,6 +108,10 @@ const defaultCommands = { | |||
| option: '--skip-user-management', | |||
| desc: 'Skip the user management module during app generation', | |||
| }, | |||
| { | |||
| option: '--unidirectional-relationships', | |||
There was a problem hiding this comment.
this doesn't look like an option, what about --generate-unilateral-relationships ?
There was a problem hiding this comment.
I don't see the need for generate.
| @@ -38,6 +38,7 @@ module.exports = { | |||
| * Converts a JDLObject to ready-to-be exported JSON entities. | |||
| * @param {Object} args - the configuration object, keys: | |||
| * @param {JDLObject} args.jdlObject - the JDLObject to convert to JSON | |||
| * @param {Boolean} [args.unidirectionalRelationships] - Whether to generate unidirectional relationships | |||
There was a problem hiding this comment.
see comment about the CLI option to update it
jdl/converters/parsed-jdl-to-jdl-object/parsed-jdl-to-jdl-object-converter.js
Show resolved
Hide resolved
mshima
force-pushed
the
skip_ci-unidirectional
branch
from
d726faa
to
817fa4c
Compare
|
Isn't it |
|
Yeah, I don't know why I've used unilateral. I was pretty tired I guess =P |
It should be the default behavior? |
|
I don't have time to spend on this. Marcelo, as I trust you (as a team member and a collaborator), go ahead. |
|
Thanks @MathieuAA. Thanks. |
|
@mshima : no, finally I can't tonight. It will be for tomorrow |
|
But go ahead and merge it. I trust you and the daily builds :-) |
|
@pascalgrimaud ok thanks. |
Related to #13885, #14196 (comment)
Closes #13305.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.