-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'publish docker' stage in Jenkinsfile #14550
Conversation
We have #13531 open to decide which command to use for docker. |
Done. |
@egvimo I think the correct was to use package or compile, but since the PR is not merged and the documentation still uses verify, you should use verify for now. You will probably need to updated test snapshots for tests to pass. |
fd1a94d
to
5d15fed
Compare
@mshima I have updated the command and the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pascalgrimaud are you already doing do release? |
Everything is ready on my computer but I'll do it this afternoon. |
Updating the CI-CD generator Jenkinsfile.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.