-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use derived constants in entity-server templates and domain #14659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcharl
force-pushed
the
constantref
branch
4 times, most recently
from
April 13, 2021 09:06
51083a2
to
14fcac5
Compare
DanielFran
requested changes
Apr 13, 2021
generators/entity-server/templates/src/main/java/package/common/inject_template.ejs
Outdated
Show resolved
Hide resolved
mshima
reviewed
Apr 13, 2021
generators/entity-server/templates/partials/it_patch_update.partial.java.ejs
Outdated
Show resolved
Hide resolved
mshima
reviewed
Apr 13, 2021
Tcharl
force-pushed
the
constantref
branch
3 times, most recently
from
April 13, 2021 20:51
08bdf31
to
d6df28a
Compare
mshima
reviewed
Apr 13, 2021
generators/entity-server/templates/partials/it_patch_update.partial.java.ejs
Outdated
Show resolved
Hide resolved
Hi @DanielFran @mshima good to go? |
@Tcharl let me handle the autoGenerate first. |
mshima
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting changes related to #14679
generators/entity-server/templates/src/test/java/package/web/rest/EntityResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
generators/entity-server/templates/src/test/java/package/web/rest/EntityResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
generators/entity-server/templates/partials/it_patch_update.partial.java.ejs
Outdated
Show resolved
Hide resolved
Tcharl
force-pushed
the
constantref
branch
3 times, most recently
from
April 15, 2021 15:22
a0e73fa
to
55c9a52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #14235
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.