-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use constants in entity-server #14703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcharl
force-pushed
the
constantref
branch
4 times, most recently
from
April 19, 2021 07:45
10ef20c
to
7a6cc7c
Compare
mshima
reviewed
Apr 19, 2021
generators/entity-server/templates/src/main/java/package/service/dto/EntityDTO.java.ejs
Outdated
Show resolved
Hide resolved
Tcharl
force-pushed
the
constantref
branch
2 times, most recently
from
April 21, 2021 11:22
e8badc3
to
d1da162
Compare
mshima
reviewed
Apr 21, 2021
generators/entity-server/templates/src/main/java/package/service/dto/EntityDTO.java.ejs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
mshima
reviewed
Apr 21, 2021
generators/entity-server/templates/src/main/java/package/service/dto/EntityDTO.java.ejs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
mshima
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #14235
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.