-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally skip frontend build tasks #14799
Conversation
Are you building the checksum across the input file? Asking because while evaluating our build scans the resulting |
Not sure I quite get your question. The checksums are calculated over a set of frontend input source files including i18 translations. As long as there is a change in one of the input files (including I believe you are looking into the 2nd OR condition. That handles a special case when the user first does the frontend build and later tries to run a maven build (first time). In that scenario, to avoid another frontend build, we check if the build output contains the |
It seems @pascalgrimaud is a little occupied. @jhipster/developers, anyone else wants to try out the change and review? I think it greatly simplifies the build time and improves the overall developer experience. |
A little had to describe, but I think your change mimics the gradle change detection which is great. The build timestamp is not relevant if the i18n files are also in the checksum, so it's fine. I will give it try today. |
Yes sorry @vishal423 : I don't have enough time these last weeks. |
I tried it today:
Looks good! FWIW, I used my jhipster7-demo project to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Works very well.
First build 58s
Second build 18s 🚀
@vishal423 Don't forget to claim the bounty, well deserved!
Sorry for the late review.
This will start a development backend with production frontend.
IMO we should rely on webpack 5 cache. |
@mshima , Thanks for review. I had the first issue in mind and will create a PR for that. |
Should include configurations that can change generated webapp:
When executing with production profile mvnw should delete checksums. |
Bounty claimed https://opencollective.com/generator-jhipster/expenses/40680 |
Awesome work @vishal423 !! |
Closes #13796
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.