-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing JDL deployment options #14945
Conversation
@mraible this PR is now in a working state, but I'm not comfortable with making "ready for review" just yet. |
Some news: I'm done adding missing deployment options. However, validations are missing so I have to add them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But I havent tested it. I'm trusting the tests here
storageType: { | ||
ephemeral: 'ephemeral', | ||
persistent: 'persistent', | ||
}, | ||
}; | ||
|
||
Options.defaults = (deploymentType = Options.deploymentType.dockerCompose) => | ||
_.omitBy( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont remmber why did omitBy here originally, so hope its still works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The omit here is useful if you have undefined values, and as the previous code generated them, the omit's role was to clean things up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And thanks for the review :)
Thanks @DanielFran for the labels! @mraible do you have time to checkout this branch and test it out? |
I tried this branch with the following JDL:
The resulting
If I try to add this to my JDL:
I get an error.
If I use the value that the prompts give me (empty parenthesis instead of blank):
It fails too:
|
Alright, thanks @mraible. I'm fixing it. |
Okay, the fixed is pushed. |
LGTM! |
@mraible if it's okay with you, I wanna create a PR to update the docs before merging it. |
This PR adds and fixes some JDL deployment options as reported by @mraible on #14817.
This PR is still a draft, so expect some changes.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.Fixes #14817