Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fork for deployments. #15392

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Jun 19, 2021

Problem: when executing jdl with a custom blueprint option (from app generator) like jhipster jdl microservice.jdl --blueprints kotlin --skip-ktlint-format, jdl command with fork serializes options back to cli options and executes deployments generators using cli with every option (eg: jhipster docker-compose --blueprints kotlin --skip-ktlint-format), causing an unknown option error.

Fork is supposed to run multiples generators in parallel making it faster, but deployments are small and will not have a big impact on the execution time.

Drop fork support for deployments, preventing the unknown option error.

Closes #14870.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima requested a review from sendilkumarn June 19, 2021 01:46
@pascalgrimaud pascalgrimaud merged commit a19537e into jhipster:main Jun 19, 2021
@mshima mshima deleted the skip_ci-deployments branch June 19, 2021 12:11
@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Sub generators should allow using blueprint custom-options
2 participants