Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liquibase incremental changelog #15464

Merged
merged 2 commits into from
Jun 26, 2021

Conversation

egvimo
Copy link
Contributor

@egvimo egvimo commented Jun 25, 2021

Attribute remarks is not allowed for add column. And fix closing change set.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member

@egvimo can you please implement https://docs.liquibase.com/change-types/community/set-column-remarks.html to add the remarks then?

@egvimo
Copy link
Contributor Author

egvimo commented Jun 25, 2021

@DanielFran I'm not very deep in the development of the generator, but I can try. I think it is not quite trivial, so I would prefer to do that in a separate PR and fix the bug with this PR, because this bug causes the application builds and tests to fail.

@egvimo egvimo changed the title Remove remarks attribute for liquibase add column Fix liquibase incremental changelog Jun 25, 2021
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielFran DanielFran merged commit 8d0f2d0 into jhipster:main Jun 26, 2021
@egvimo egvimo deleted the bugfix/liquibase-add-column branch June 26, 2021 07:59
@pascalgrimaud pascalgrimaud added this to the 7.2.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants