Replace deprecated API for Kafka testcontainer #15602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielFran
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Better to use DOCKER_KAKFA constant: https://github.com/jhipster/generator-jhipster/blob/main/generators/generator-constants.js#L65
generators/server/templates/src/test/java/package/web/rest/KafkaResourceIT.java.ejs
Outdated
Show resolved
Hide resolved
egvimo
force-pushed
the
bugfix/kafka-test-docker-image
branch
from
4510616
to
b07c58f
Compare
|
I've pushed a clean commit (for a clean history). :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated Java API for Kafka testcontainer and use the
DockerImageNameclass.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.