Fix visualization of large images on angular #15644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big images not are loaded after click on it on chrome 91.0.4472.124 or Microsoft Edge 91.0.864.67 under windows 10. Works fine on Firefox.
The error can be reproduced with this project.
https://github.com/CGarces/testimgJHipster
Fails with the bigger image at fake data, the others works fine.
https://github.com/CGarces/testimgJHipster/tree/main/src/main/resources/config/liquibase/fake-data/blob
And can be fixed with this patch
https://github.com/CGarces/testimgJHipster/compare/fix_img?expand=1
The error only happens if is loaded by the openFile function.
The proposed solution just works for me on angular, I haven't test the issue on other web frameworks. I don't know why the iframe is needed, please give me some background about that to improve the PR.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.