Implement modular java/spring-boot generator. #15726
Conversation
mshima
force-pushed
the
skip_ci-modular_java_config
branch
from
2867bba
to
c9021e0
Compare
| default: () => this._getDefaultPackageName(), | ||
| }, | ||
| { | ||
| name: BUILD_TOOL, |
There was a problem hiding this comment.
If the filetree mentionned earlier is possible, we could put that question in generator->builTool->prompt.js
There was a problem hiding this comment.
prompts.js is possible but I don't think it's too useful.
It would require to pass the generator as parameter or bind context to the function.
There was a problem hiding this comment.
Just to avoid the previous generator in the chain to reference properties/prompts of the next ones. So that contributor will know were to find the information, and generators will be really independent together (not bound by a parent->childor caller->callee relationship)
| return { | ||
| async writeFiles() { | ||
| if (this.shouldSkipFiles()) return; | ||
| await this.writeFilesToDisk(files); |
There was a problem hiding this comment.
So to include in the superclass and avoid repeating
Improves error handling.
|
Thanks @pascalgrimaud |
Required to execute async methods ordered.
|
@mshima : approved. Could you add some documentation for the next release plz? |
|
@pascalgrimaud I will convert them to mjs before they can be considered stable, otherwise we will have to migrate at jhipster 8 development cicle only. |
Internal:
modular generators:
spring-boot generator generates a spring initializr like project.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.