Importing The Same JDL File Multiple Times Will Lead to Duplicated Menus Items

[akang]

Importing The Same JDL File Multiple Times Will Lead to Duplicated Menus Items

Fix #15745

[CLAassistant]

All committers have signed the CLA.

[akang]

Hi all,

First PR for this project. Just wondering if I have ticked all the right boxes as far as the PR submission is concerned?

thanks
aka

[mshima]

In angular framework, this is the test that check needles duplication:

generator-jhipster/test/needle-api/needle-client-angular.spec.js

Lines 69 to 75 in 4fec426

	it('should bail on any file change adding same needles again', async () => {
	await runResult
	.create('jhipster-myblueprint:client')
	.withGenerators([[mockBlueprintSubGen, 'jhipster-myblueprint:client']])
	.withOptions({ fromCli: true, force: false, bail: true, skipChecks: true, skipInstall: true })
	.run();
	});

Would be nice to add to vue, but not required.

[mshima]

Suggested change

	// check if regex is valid. If not, issue warning and we skip fake data generation.
	try {
	// eslint-disable-next-line no-new
	new RegExp(field.fieldValidateRulesPattern);
	} catch (e) {
	console.log(
	`${chalk.yellowBright('WARNING!')} ${field.fieldName} pattern is not valid: ${
	field.fieldValidateRulesPattern
	}. Skipping generating fake data. `
	);
	return undefined;
	}
	const generated = field.createRandexp().gen();
	const dataGenerator = field.createRandexp();
	if (!dataGenerator) {
	return undefined;
	}
	const generated = dataGenerator.gen();

• Move the regex check to:
  

  generator-jhipster/utils/field.js

  Line 374 in cbd88e4

  field.createRandexp = () => faker.createRandexp(field.fieldValidateRulesPattern);

  
  like

    field.createRandexp = () => {
      // check field.fieldValidateRulesPattern and return undefined.
      return faker.createRandexp(field.fieldValidateRulesPattern);
    }

• Replace console.log with this.warning.

[akang]

Done

[akang]

I used the wrong email when pushing the codes and now the "license/cla" agreement is unsigned.

@mshima is there a workaround to get this task ticked off?

[mshima]

@akang You should use only the one with the email you signed the cla, otherwise it won’t become green.
Squashing the commit should me enough.