-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blueprint templates folders. #15970
Conversation
hi @mshima Since the 7.2.0 we can't use it anymore because of an error and I guess this modification is related to this. This is my error
I can see the following method I guess this code should be applied only on a "real" extended JHipster generator. there is my sub generator: https://github.com/entando/entando-blueprint/blob/master/generators/entity-microfrontend/index.js Thanks! |
@avdev4j having the folder called Anyway we should catch the error and log to debug. IMO the folder name should always match the package name https://github.com/entando/entando-blueprint/blob/0a15a091902a1a13dfdb4b8927ad2f3b445c977f/package.json#L2.
Yes, but I don't see this as a problem, if the file is not found, it should ignore. |
Great @mshima I can confirm you it's working by renaming the folder. the strange thing is it's working like a charm on Linux OS with the old folder name. Anyway, it's was quite tricky but easy to fix. I'll do PR in incoming days, I can reproduce it easily! |
Is it |
Yes for the package name. For the folder: Long answer: if needed.
So if it's working as it is I don't see the need for changing, but for best practices new packages should start with |
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.