No Database selection project generation issue fix

[yuvarajsanjeevi]

Fix #15507

---

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• The JDL part is updated if necessary
• jhipster-online is updated if necessary
• Documentation is added/updated where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[mshima]

This PR looks good, but this will not close the issue because it doesn't fixes the problems outlined by @mraible in the daily builds.
I've triggered a manual build with this branch at https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/1141429995.

And since we are going modular, we should add a no-database test to main generator.

[mshima]

@yuvarajsanjeevi do you want to keep working on the PR or should I change the description and merge?

[yuvarajsanjeevi]

@mshima

I could see the parameters in the generated daily build

JHI_LIB_REPO=https://github.com/jhipster/jhipster-bom.git
JHI_LIB_BRANCH=auto
JHI_LIB_HOME=/home/runner/work/jhipster-daily-builds/jhipster-daily-builds/jhipster-bom
JHI_GEN_REPO=https://github.com/yuvarajsanjeevi/generator-jhipster.git
JHI_GEN_BRANCH=main
JHI_FOLDER_APP=/home/runner/work/jhipster-daily-builds/jhipster-daily-builds/app
JHI_JDL_APP=
JHI_APP=ngx-nodatabase-jwt

But the fix is in the branch fix#15507. Kindly run the daily build on fix#15507 branch please

[mshima]

You are right https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/1142420695.
Can you add gateway tests to daily builds to cover the original issue?

[yuvarajsanjeevi]

Do you mean adding new samples for gateway with no db in https://github.com/hipster-labs/jhipster-daily-builds and defining workflow in the no-database.yaml or adding tests inside test-integration of jhipster codebase. Please confirm

[mshima]

Do you mean adding new samples for gateway with no db in https://github.com/hipster-labs/jhipster-daily-builds and defining workflow in the no-database.yaml

Yes please.

[yuvarajsanjeevi]

Raised PR hipster-labs/jhipster-daily-builds#124

[mshima]

https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/1152758979

[yuvarajsanjeevi]

@mshima Please let me know what needs to be done next

[mshima]

Let’s ask @DanielFran about this hard requirement jhipster-bom has on spring-data-common.

[mraible]

Can you help with this issue @DanielFran?

[DanielFran]

Will try to look at it during the week-end

[Tcharl]

Also I guess for pagination: Page is included in spring-data

[mshima]

LGTM

[mshima]

@yuvarajsanjeevi congrats on the first contribution.

[yuvarajsanjeevi]

@mshima Thank you for your great support.

[jdubois]

@yuvarajsanjeevi just to be sure, did you send this OpenCollective invoice https://opencollective.com/generator-jhipster/expenses/48874 ? (I want to be sure it's you, before paying)

[yuvarajsanjeevi]

@jdubois Yes I'm the one who raised this invoice