-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Database selection project generation issue fix #15978
Conversation
This PR looks good, but this will not close the issue because it doesn't fixes the problems outlined by @mraible in the daily builds. And since we are going modular, we should add a no-database test to main generator. |
@yuvarajsanjeevi do you want to keep working on the PR or should I change the description and merge? |
I could see the parameters in the generated daily build JHI_LIB_REPO=https://github.com/jhipster/jhipster-bom.git But the fix is in the branch fix#15507. Kindly run the daily build on fix#15507 branch please |
You are right https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/1142420695. |
Do you mean adding new samples for gateway with no db in https://github.com/hipster-labs/jhipster-daily-builds and defining workflow in the no-database.yaml or adding tests inside test-integration of jhipster codebase. Please confirm |
Yes please. |
Raised PR hipster-labs/jhipster-daily-builds#124 |
@mshima Please let me know what needs to be done next |
Let’s ask @DanielFran about this hard requirement jhipster-bom has on spring-data-common. |
Can you help with this issue @DanielFran? |
Will try to look at it during the week-end |
Also I guess for pagination: |
generators/server/templates/src/main/java/package/config/WebConfigurer.java.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/main/java/package/config/WebConfigurer.java.ejs
Outdated
Show resolved
Hide resolved
generators/server/templates/src/main/java/package/config/WebConfigurer.java.ejs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yuvarajsanjeevi congrats on the first contribution. |
@mshima Thank you for your great support. |
@yuvarajsanjeevi just to be sure, did you send this OpenCollective invoice https://opencollective.com/generator-jhipster/expenses/48874 ? (I want to be sure it's you, before paying) |
@jdubois Yes I'm the one who raised this invoice |
Fix #15507
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.