Readd server configuration task. #16104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mshima
changed the title
Tcharl
reviewed
Sep 4, 2021
|
|
||
| const databaseType = config.databaseType; | ||
| if (databaseType === NO_DATABASE) { | ||
| config.devDatabaseType = NO_DATABASE; |
Tcharl
reviewed
Sep 4, 2021
| config.enableHibernateCache = false; | ||
| config.skipUserManagement = true; | ||
| } else if ([MONGODB, NEO4J, COUCHBASE, CASSANDRA].includes(databaseType)) { | ||
| config.devDatabaseType = databaseType; |
There was a problem hiding this comment.
devDatabasetype is always populated by defaultConfig.
Should be removed when #15815 (comment) is fixed.
Tcharl
reviewed
Sep 4, 2021
| @@ -558,4 +579,54 @@ module.exports = class JHipsterServerGenerator extends BaseBlueprintGenerator { | |||
| if (useBlueprints) return; | |||
| return this._end(); | |||
| } | |||
|
|
|||
| _configureServer(config = this.jhipsterConfig) { | |||
There was a problem hiding this comment.
Isn't it a derived thing? I would have let it in the gen-base derived props
There was a problem hiding this comment.
They are server configurations that depends on others configurations.
Otherwise we can have situations like #16103.
Situations like this will not happen in the modular implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16103
Closes #16010.
Partially reverts #15846.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.