Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally publish to docker hub. #16366

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Sep 20, 2021

Related to #15881


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud
Copy link
Member

@mshima : thanks for your work here. Do I need to add some secret to the project ?

@mshima
Copy link
Member Author

mshima commented Sep 21, 2021

@pascalgrimaud yes, DOCKERHUB_USERNAME and DOCKERHUB_TOKEN.

@DanielFran
Copy link
Member

@pascalgrimaud can you create the variables to merge this PR?

@mshima
Copy link
Member Author

mshima commented Sep 26, 2021

The step is conditional on the variable.
No need to create now.

@DanielFran
Copy link
Member

DanielFran commented Sep 26, 2021

Yes, I saw it. Just to be ready to create docker images...

@pascalgrimaud
Copy link
Member

ok I'm looking into it

@pascalgrimaud pascalgrimaud merged commit 730007f into jhipster:main Sep 26, 2021
@pascalgrimaud pascalgrimaud added this to the 7.3.0 milestone Sep 26, 2021
@vishal423
Copy link
Contributor

@pascalgrimaud , Can you please also make DOCKERHUB_USERNAME and DOCKERHUB_TOKEN secrets as organizational secrets available to the svelte blueprint project?

@pascalgrimaud
Copy link
Member

Ok, will do it tomorrow.
Ping me if I forget :-)

@mshima mshima deleted the skip_ci-docker_hub branch October 10, 2021 20:43
@vishal423
Copy link
Contributor

@pascalgrimaud ping

@pascalgrimaud
Copy link
Member

Thanks @vishal423 !
Just done for this project: https://github.com/jhipster/generator-jhipster-svelte

@vishal423
Copy link
Contributor

Thanks @pascalgrimaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants