-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally publish to docker hub. #16366
Conversation
@mshima : thanks for your work here. Do I need to add some secret to the project ? |
@pascalgrimaud yes, DOCKERHUB_USERNAME and DOCKERHUB_TOKEN. |
@pascalgrimaud can you create the variables to merge this PR? |
The step is conditional on the variable. |
Yes, I saw it. Just to be ready to create docker images... |
ok I'm looking into it |
@pascalgrimaud , Can you please also make |
Ok, will do it tomorrow. |
@pascalgrimaud ping |
Thanks @vishal423 ! |
Thanks @pascalgrimaud |
Related to #15881
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.