-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Angular] Loop for enums #16475
[Angular] Loop for enums #16475
Conversation
1f85b8e
to
fd2fa49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion is to use <%- _.lowerFirst(importedType) %>Values
instead of <%- importedType %>s
, since it's not a class and would be more descriptive.
But looks good as it is, your call.
fd2fa49
to
512ec2a
Compare
@mshima done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
...ates/angular/src/main/webapp/app/entities/update/entity-management-update.component.html.ejs
Outdated
Show resolved
Hide resolved
512ec2a
to
90439e9
Compare
90439e9
to
9eb4d18
Compare
@mshima done :) |
Use v-for instead of generated code for enums for better maintainance Followup of jhipster#16475
Map for loop for enums instead of generated code Follows jhipster#16475
Use v-for instead of generated code for enums for better maintainance Followup of jhipster#16475
Map for loop for enums instead of generated code Follows jhipster#16475
Fix #16407
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.