Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Loop for enums #16475

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[Angular] Loop for enums #16475

merged 1 commit into from
Sep 30, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Sep 28, 2021 •
edited
Loading

Fix #16407

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert changed the title [Angular] Loop for enums WIP: [Angular] Loop for enums Sep 28, 2021
@qmonmert qmonmert closed this Sep 29, 2021
@qmonmert qmonmert reopened this Sep 29, 2021
@qmonmert qmonmert changed the title WIP: [Angular] Loop for enums [Angular] Loop for enums Sep 29, 2021
mshima
mshima approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion is to use <%- _.lowerFirst(importedType) %>Values instead of <%- importedType %>s, since it's not a class and would be more descriptive.
But looks good as it is, your call.

@qmonmert
Copy link
Contributor Author

@mshima done

mshima
mshima reviewed Sep 30, 2021
View reviewed changes
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

...ates/angular/src/main/webapp/app/entities/update/entity-management-update.component.html.ejs Outdated Show resolved Hide resolved
@qmonmert
Copy link
Contributor Author

@mshima done :)

@mshima mshima merged commit cb53728 into jhipster:main Sep 30, 2021
@pascalgrimaud pascalgrimaud added this to the 7.3.0 milestone Oct 1, 2021
swarajsaaj added a commit to swarajsaaj/generator-jhipster that referenced this pull request Oct 3, 2021
@swarajsaaj
[vue] Use v-for instead of generation for enums
d310c6f 
Use v-for instead of generated code for enums for better maintainance

Followup of jhipster#16475
swarajsaaj added a commit to swarajsaaj/generator-jhipster that referenced this pull request Oct 3, 2021
@swarajsaaj
[react] map for loop for enums
7ec30c2 
Map for loop for enums instead of generated code

Follows jhipster#16475
@swarajsaaj swarajsaaj mentioned this pull request Oct 3, 2021
Merged
6 tasks
swarajsaaj added a commit to swarajsaaj/generator-jhipster that referenced this pull request Oct 7, 2021
@swarajsaaj
[vue] Use v-for instead of generation for enums
a8318bc 
Use v-for instead of generated code for enums for better maintainance

Followup of jhipster#16475
swarajsaaj added a commit to swarajsaaj/generator-jhipster that referenced this pull request Oct 7, 2021
@swarajsaaj
[react] map for loop for enums
08a2291 
Map for loop for enums instead of generated code

Follows jhipster#16475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima approved these changes

@DanielFran DanielFran DanielFran approved these changes

Assignees
No one assigned
Labels
theme: angular
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

Angular: Loop for enums
4 participants
@qmonmert @mshima @DanielFran @pascalgrimaud