-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using mavenLocal() in build.gradle? #16863
Conversation
Yes, I in fact thought we removed it already. |
Ok, I'll make the PR. |
Sorry for the mess, I've used hub cli and it created the PR against the old "master" branch. Now it's against "main". |
I've tried to regenerate snapshots, but for some reason it changes a lot of files due to different convention for strings and escaping chars (maybe it's related to WSL2 usage). I've destroyed the last commit and force pushed the only commit containing the actual code. |
JHipster uses |
Hey @mshima I'm new to CI concepts and practices.. ':D |
Ah you are right @mshima . Didn't remember why we kept it. |
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@atomfrede what do you think about this now? |
Sorry missed the review request. |
Overview of the feature request
While reading the Gradle documentation to configure Gradle to use my private Nexus repository, I ran into this advice in the official documentation regarding maven repositories:
Existing code:
generator-jhipster/generators/server/templates/build.gradle.ejs
Lines 283 to 285 in 1b76ae1
Motivation for or Use Case
As stated in the doc's chapter "Obtaining module metadata":
(penultimate point)
(callout)
Related issues or PR