Upgrade to angular 13. #16961
Merged
Upgrade to angular 13. #16961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme: angular
theme: dependencies
mshima
force-pushed
the
skip_ci-angular13
branch
from
8a1509a
to
7bac80b
Compare
qmonmert
reviewed
Nov 9, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@mshima https://github.com/ng-bootstrap/ng-bootstrap/releases/tag/11.0.0 has been released |
|
PR is ready. |
Tcharl
reviewed
Dec 26, 2021
| jest.spyOn(service, 'save').mockReturnValue(of({})); | ||
| <%_ if (enableTranslation) { _%> | ||
| mockLanguageService.currentLang = '<%= nativeLanguage %>'; | ||
| mockTranslateService.currentLang = '<%= nativeLanguage %>'; |
|
Everything LGTM: feel free to merge |
DanielFran
approved these changes
Dec 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 13 generated packages are esm now.
Note: generated project is commonjs.
ESM support is done by tooling (typescript, angular compiler, jest, webpack)
Closes #16960.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.