Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node community is adopting esm and commonjs packages cannot depend on esm packages.
By allowing blueprints to switch to esm, will make easier esm adoption on generator-jhipster probably for v8.
Why this is needed?
require()
doesn't exist on an esm module. It was replaced by the asyncimport()
.So every operation that depend on dynamically loading a module (like a blueprint), need to be converted to async.
A constructor is always sync, as workaround, an async
_postConstruct
needs to be used to wait for the blueprint to be instantiated.Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.