Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AWS Tomcat version [skip-ci] #17002

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

fresnault
Copy link
Contributor

@fresnault fresnault commented Nov 12, 2021

Summary:

Upgrade AWS beanstalk platform
FROM => Tomcat 8.5 with Java 8 running on 64bit Amazon Linux
TO => Tomcat 8.5 with Corretto 11 running on 64bit Amazon Linux 2

Fix #16152
Fix #12394

Context:

The most recent version of Jhipster requires a minimum JDK 11. However, the selected beanstalk platform only supported version JDK 8.
Old tomcat does not deploy Jhipster, which causes 404 errors in both issues.

Fix:

The function filterSolutionStackNames returns the first result with pattern "Tomcat 8" which is wrong. I propose to change the pattern with "Tomcat 8.5 Corretto 11" to fix.

console.table(data.SolutionStacks.filter((element) => element.includes('Tomcat 8')));

┌─────────┬────────────────────────────────────────────────────────────────┐
│ (index) │                             Values                             │
├─────────┼────────────────────────────────────────────────────────────────┤
│    0    │ '64bit Amazon Linux 2018.03 v3.4.12 running Tomcat 8.5 Java 8' │
│    1    │ '64bit Amazon Linux 2018.03 v3.4.10 running Tomcat 8.5 Java 8' │
│    2    │  '64bit Amazon Linux 2018.03 v3.4.0 running Tomcat 8 Java 8'   │
│    3    │  '64bit Amazon Linux 2 v4.2.7 running Tomcat 8.5 Corretto 11'  │
│    4    │  '64bit Amazon Linux 2 v4.2.7 running Tomcat 8.5 Corretto 8'   │
└─────────┴────────────────────────────────────────────────────────────────┘
console.table(data.SolutionStacks.filter((element) => element.includes('Tomcat 8.5 Corretto 11')));

┌─────────┬──────────────────────────────────────────────────────────────┐
│ (index) │                            Values                            │
├─────────┼──────────────────────────────────────────────────────────────┤
│    0    │ '64bit Amazon Linux 2 v4.2.7 running Tomcat 8.5 Corretto 11' │
└─────────┴──────────────────────────────────────────────────────────────┘

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

upgrade from tomcat 8 (JDK8) to tomcat 8.5 (JDK11)

Fix jhipster#16152
@CLAassistant
Copy link

CLAassistant commented Nov 12, 2021

CLA assistant check)
All committers have signed the CLA.

@fresnault fresnault marked this pull request as ready for review November 13, 2021 17:18
@pascalgrimaud pascalgrimaud merged commit b998108 into jhipster:main Nov 19, 2021
@pascalgrimaud
Copy link
Member

Thanks and congrats for your 1st contribution @fresnault
I didn't test it as I don't have AWS account to do it, so trusting you on this :)

@pascalgrimaud pascalgrimaud added this to the 7.4.0 milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Status 404 – Not Found when Deploy to AWS jhipster aws
3 participants