Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts to upgrade on files conflicts. #17095

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Nov 22, 2021

When file conflicts, it becomes invalid.
So prettier fails to parse its configuration (package.json, .prettierrc) or to parse the file.
Upgrade must ignore prettier errors.

Related to #17072.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima requested a review from mraible November 22, 2021 22:25
@pascalgrimaud pascalgrimaud merged commit ff2956f into jhipster:main Nov 23, 2021
@pascalgrimaud pascalgrimaud added this to the 7.4.1 milestone Nov 30, 2021
@mshima mshima deleted the skip_ci-upgrade branch December 7, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants