Improvements to microfrontend support. #17128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pascalgrimaud I think we should prepare v7.4.1. There is enough fixes for a patch release. |
|
Ok @mshima : I'll take care of a new release. Probably this friday as I'm not sure to have time until this day |
|
@pascalgrimaud thanks. |
Tcharl
reviewed
Nov 29, 2021
|
|
||
| if (this.jhipsterConfig.applications && !this.entityConfig.skipClient) { | ||
| const remoteConfig = this.jhipsterConfig.applications[this.entityConfig.microserviceName]; | ||
| if (remoteConfig.clientFramework === 'vue') { |
There was a problem hiding this comment.
Temporary, will drop it soon, once angular menu moves to the microservice side.
I will create the PR removing instead of creating the PR with the constant.
|
Is monolitic gateway aggregating all the frontend code for all the microservice still a thing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jhipster-internals:
microfrontend support:
Related to #17031
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.