Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17322 - shall generate pagination for the frontend even if gateway h… #17342

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

ko5tik
Copy link
Contributor

@ko5tik ko5tik commented Dec 18, 2021

…as no database specified

Pagination shall be generated for gateway templates even it gateway itself has no database


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

This PR fixes issue #17322

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be applied to microservice entities only.

generators/entity/index.js Outdated Show resolved Hide resolved
generators/entity/index.js Outdated Show resolved Hide resolved
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshima mshima merged commit 11f292e into jhipster:main Dec 21, 2021
@pascalgrimaud pascalgrimaud added this to the 7.5.0 milestone Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants