Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cypress session #17451

Merged
merged 5 commits into from
Jan 1, 2022
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 31, 2021

Fixes #16545.

  • No page visits is done at login process.
  • Removes forced clicks.
  • Reduces differences between authentication implementations.
  • Reduces differences between client framework implementations.
  • Big gain in oauth2 authentication performance.
  • Small loss in jwt/session authentication performance due to each test cleanup overhead.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as draft December 31, 2021 19:39
@mshima mshima marked this pull request as ready for review January 1, 2022 15:05
@mshima
Copy link
Member Author

mshima commented Jan 1, 2022

Thanks @qmonmert

@mshima mshima merged commit 0ed31bc into jhipster:main Jan 1, 2022
@mshima mshima deleted the skip_ci-cypress_session branch January 1, 2022 20:44
@qmonmert
Copy link
Contributor

qmonmert commented Jan 1, 2022

@mshima you're welcome!

@pascalgrimaud pascalgrimaud added this to the 7.5.0 milestone Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oauth2 cypress tests too slow because of login logout
3 participants