Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use positive conditional instead of negation in reactive templates #17544

Merged
merged 5 commits into from
Jan 19, 2022

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Jan 11, 2022

Only cosmetic, but improves the developper experience and reduce the cognitive overhead


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl Tcharl force-pushed the skip_ci-spring-boot_2.6.0_ocd branch from 0882c62 to 4e36686 Compare January 12, 2022 20:39
@github-actions github-actions bot added the theme: dependencies Pull requests that update a dependency file label Jan 16, 2022
@Tcharl Tcharl force-pushed the skip_ci-spring-boot_2.6.0_ocd branch from 98e208b to fbab2d2 Compare January 16, 2022 20:47
@Tcharl Tcharl changed the title WIP: Use positive conditional instead of negation in reactive templates Use positive conditional instead of negation in reactive templates Jan 16, 2022
@Tcharl
Copy link
Contributor Author

Tcharl commented Jan 16, 2022

Someone to review? It's only cosmetic but small things makes the overall better :-)

@DanielFran @mshima ?

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshima mshima merged commit c81f34f into jhipster:main Jan 19, 2022
@pascalgrimaud pascalgrimaud added this to the 7.6.0 milestone Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants