Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mocha-expect-snapshot and improve some tests. #17648

Merged
merged 4 commits into from
Jan 22, 2022

Conversation

mshima
Copy link
Member

@mshima mshima commented Jan 22, 2022

  • Reduce upgrade test by 2-3min
  • Remove some duplicated tests.
  • Fix test name.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added theme: dependencies Pull requests that update a dependency file theme: jhipster-internals labels Jan 22, 2022
@DanielFran
Copy link
Member

@mshima Trusting on it

@DanielFran DanielFran merged commit e478e38 into jhipster:main Jan 22, 2022
@mshima mshima deleted the skip_ci-tests branch January 22, 2022 19:37
@pascalgrimaud pascalgrimaud added this to the 7.6.0 milestone Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: jhipster-internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants