Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed timing attack vulnerability in TokenProvider #2096

Merged
merged 2 commits into from Oct 16, 2015
Merged

fixed timing attack vulnerability in TokenProvider #2096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79fe562
fixed timing attack vulnerability in TokenProvider #2095
Oct 6, 2015
439cbe9
fixed extra parenthesis
Oct 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion app/templates/src/main/java/package/security/xauth/_TokenProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,23 @@ public boolean validateToken(String authToken, UserDetails userDetails) {
long expires = Long.parseLong(parts[1]);
String signature = parts[2];
String signatureToMatch = computeSignature(userDetails, expires);
return expires >= System.currentTimeMillis() && signature.equals(signatureToMatch);
return expires >= System.currentTimeMillis() && constantTimeEquals(signature, signatureToMatch);
}

/**
* String comparison that doesn't stop at the first character that is different but instead always
* iterates the whole string length to prevent timing attacks.
*/
private boolean constantTimeEquals(String a, String b) {
if (a.length() != b.length()) {
return false;
} else {
int equal = 0;
for (int i = 0; i < a.length(); i++) {
equal |= a.charAt(i) ^ b.charAt(i);
}
return equal == 0;
}
}

}