Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some templates permissions and convert blueprint cli to cjs #23442

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Sep 7, 2023

  • fix 2 templates permission.
  • js executables should be written in cjs, otherwise can fail on windows.

Related to #23440


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit ca02179 into jhipster:main Sep 8, 2023
20 checks passed
@DanielFran
Copy link
Member

@mshima Since @deepu105 did the latest release, the permissions seems not to be related with my setup.
Maybe we should do another release soon to check that all file permissions are ok now...

@mshima mshima deleted the skip_ci-permissions branch September 28, 2023 21:02
@deepu105 deepu105 added this to the 8.0.0-rc.1 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants