-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid repeating the entity's name on each endpoint #23554
Avoid repeating the entity's name on each endpoint #23554
Conversation
...rators/server/templates/entity/src/main/java/package/web/rest/_EntityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
...rators/server/templates/entity/src/main/java/package/web/rest/_EntityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
...rators/server/templates/entity/src/main/java/package/web/rest/_EntityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
I've remembered I tried this before but it won't work. |
Why change the the behavior? Is that the only way to do it? It would make more sense to have it |
I agree with the change before final v8. |
wouldn't use 2 separate PRs break the tests? |
@amatosg fill free to change here, another PR would be more concise. |
@mshima any idea what else needs to be changed? tests are failing but I cannot find the solution |
Merge Request from upstream
...ver/templates/src/main/java/_package_/_entityPackage_/_partials_entity_/get_all_template.ejs
Outdated
Show resolved
Hide resolved
...er/templates/src/main/java/_package_/_entityPackage_/web/rest/_entityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
...er/templates/src/main/java/_package_/_entityPackage_/web/rest/_entityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
...er/templates/src/main/java/_package_/_entityPackage_/web/rest/_entityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
...er/templates/src/main/java/_package_/_entityPackage_/web/rest/_entityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
...er/templates/src/main/java/_package_/_entityPackage_/web/rest/_entityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
...er/templates/src/main/java/_package_/_entityPackage_/web/rest/_entityClass_Resource.java.ejs
Outdated
Show resolved
Hide resolved
Need to adjust more apis. Line 183 in e68a3a4
|
@mshima looks like your changes were enough. Thank you! |
@amatosg Can you look in the jhipster.github.io to see if there is any needed update in the documentation? |
Closes #23553 Remove entity's name from each endpoint
With this changes, each endpoint doesn't has to have the entity's name on each endpoint.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.