Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeating the entity's name on each endpoint #23554

Merged

Conversation

amatosg
Copy link
Contributor

@amatosg amatosg commented Sep 18, 2023

Closes #23553 Remove entity's name from each endpoint

With this changes, each endpoint doesn't has to have the entity's name on each endpoint.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@amatosg amatosg changed the title Closes #23553 Avoid repeating the entity's name on each endpoint Avoid repeating the entity's name on each endpoint Sep 18, 2023
@mshima
Copy link
Member

mshima commented Sep 22, 2023

I've remembered I tried this before but it won't work.
The search api is different api/_search/entity-name.
Is this api compliant with conventions?

@amatosg
Copy link
Contributor Author

amatosg commented Oct 2, 2023

The search api is different api/_search/entity-name.

Why change the the behavior? Is that the only way to do it? It would make more sense to have it api/entity-name/_search

@mshima
Copy link
Member

mshima commented Oct 2, 2023

The search api is different api/_search/entity-name.

Why change the the behavior? Is that the only way to do it? It would make more sense to have it api/entity-name/_search

I agree with the change before final v8.
I prefer to be handled in another PR if someone is willing to do.

@amatosg
Copy link
Contributor Author

amatosg commented Oct 2, 2023

wouldn't use 2 separate PRs break the tests?

@mshima
Copy link
Member

mshima commented Oct 3, 2023

@amatosg fill free to change here, another PR would be more concise.

@amatosg
Copy link
Contributor Author

amatosg commented Oct 30, 2023

@mshima any idea what else needs to be changed? tests are failing but I cannot find the solution

Merge Request from upstream
@mshima
Copy link
Member

mshima commented Oct 31, 2023

Need to adjust more apis.
At least

@amatosg
Copy link
Contributor Author

amatosg commented Oct 31, 2023

@mshima looks like your changes were enough. Thank you!

@DanielFran
Copy link
Member

DanielFran commented Oct 31, 2023

@amatosg Can you look in the jhipster.github.io to see if there is any needed update in the documentation?

@DanielFran DanielFran merged commit eec61eb into jhipster:main Oct 31, 2023
48 checks passed
@deepu105 deepu105 added this to the 8.0.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend: Avoid repeating the entity's name on each endpoint
4 participants