Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java and Node versions supported #23975

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Add Java and Node versions supported #23975

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb3a65b
Add Java and Node versions supported
mraible Oct 24, 2023
8865a80
Update based on IntelliJ recommendations
mraible Oct 24, 2023
4bad155
Clarify
mraible Oct 24, 2023
0b4a2a8
Tighten things up with Prettier
mraible Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ Please read our [guidelines](/CONTRIBUTING.md#submitting-an-issue) before submit

We are honoured by any contributions you may have small or large. Please refer to our [contribution guidelines and instructions document](https://github.com/jhipster/generator-jhipster/blob/main/CONTRIBUTING.md) for any information about contributing to the project.

## Java and Node versions

The following Java and Node combinations are tested and verified by GitHub Actions:

| Java | Node | Status |
|------|------|--- ----|
| 21 | 20 | ✅ |
| 17 | 18 | ✅ |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshima It'd be awesome if the status icon could be dynamic based on the matrix results.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it’s possibe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this table accurate or does it need to be updated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this table accurate or does it need to be updated?

I don't know how are we going to add the node/java matrix yet.
From the table I would think that we are test node20/java21 together and node18/java17 together.
Node 20 should be ok to generate applications, but test is broken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should create the matrix workflows at daily builds.
We can add a workflow for each combination, badges will be available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!


## Sponsors

Support this project by becoming a sponsor! [Become a sponsor](https://opencollective.com/generator-jhipster) or [learn more about sponsoring the project](https://www.jhipster.tech/sponsors/).
Expand Down
Loading