Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use self reference #24431

Merged
merged 2 commits into from
Dec 4, 2023
Merged

don't use self reference #24431

merged 2 commits into from
Dec 4, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 1, 2023

Calling a @Async without been proxied is reported by sonar as a code smell.
Add a non async internal method since calling a @Async method from a @Async method creates an unnecessary twice async.

Fixes jhipster/generator-jhipster-native#101
Implement #24034 (review)


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

mraible
mraible previously approved these changes Dec 1, 2023
@DanielFran DanielFran merged commit a25c4af into jhipster:main Dec 4, 2023
48 checks passed
@mshima mshima deleted the main-service branch December 4, 2023 20:38
@deepu105 deepu105 added this to the 8.1.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException in MailService with Spring CGLIB Proxies
4 participants