[Angular] Angular DI: Using Inject instead of Constructor #24585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonmert
force-pushed
the
angularinject
branch
from
bcd5687
to
45bfc9d
Compare
qmonmert
force-pushed
the
angularinject
branch
6 times, most recently
from
235a11c
to
9f793be
Compare
qmonmert
force-pushed
the
angularinject
branch
from
9f793be
to
55e16f9
Compare
mshima
previously approved these changes
Dec 18, 2023
Comment on lines
28
to
30
| constructor() { | ||
| super(); | ||
| } |
There was a problem hiding this comment.
Unused constructor
Suggested change
| constructor() { | |
| super(); | |
| } |
| import { RouterStateSnapshot, TitleStrategy } from "@angular/router"; | ||
| <%_ if (enableTranslation) { _%> | ||
| import { TranslateService } from "@ngx-translate/core"; | ||
| <%_ } _%> | ||
|
|
||
| @Injectable() | ||
| export class AppPageTitleStrategy extends TitleStrategy { | ||
|
|
||
| constructor(<%_ if (enableTranslation) { _%>private translateService: TranslateService<%_ } _%>) { | ||
| <%_ if (enableTranslation) { _%>private translateService = inject(TranslateService);<%_ } _%> |
There was a problem hiding this comment.
Suggested change
| <%_ if (enableTranslation) { _%>private translateService = inject(TranslateService);<%_ } _%> | |
| <%_ if (enableTranslation) { _%> | |
| private translateService = inject(TranslateService); | |
| <%_ } _%> |
mshima
approved these changes
Dec 18, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.