Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MSSQL Server testcontainer setup for integration tests #25108

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

yhao3
Copy link
Contributor

@yhao3 yhao3 commented Feb 6, 2024

Description

  • Explicitly accepting the license programmatically: This eliminates the need for users to manually create a container-license-acceptance.txt file, streamlining setup.

  • Removing outdated comments: The configuration file has been updated to remove comments about manual license acceptance, as this is now handled automatically.

Additional notes

  • This change is aligned with the official Testcontainers documentation for MSSQL Server modules.
  • The documentation states that license acceptance can be done either programmatically or via a resource file, and this PR adopts the programmatic approach for a more streamlined experience.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we should generate with it enabled.
We cannot accept the license for the end user.

Maybe we should generate commented.

…tance

Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@mshima mshima merged commit b10b399 into jhipster:main Feb 7, 2024
52 checks passed
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants