-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos #25288
Typos #25288
Conversation
@@ -27,7 +27,7 @@ exports[`generator - Knative Using Helm generator type MySQL and PostgreSQL micr | |||
|
|||
## Preparation | |||
|
|||
- Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and kntaive installed | |||
- Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and knative installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like Istio and Knative should both be capitalized because they're nouns, not commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 😉
@@ -2,7 +2,7 @@ | |||
|
|||
## Preparation | |||
|
|||
* Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and kntaive installed | |||
* Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and Knative installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have istio and Knative installed | |
* Knative depends on Istio. In order to use the manifests generated by k8s-knative generator, you should have Istio and Knative installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@qmonmert Looks good! I think you need to update the snapshot for tests to pass. |
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.