Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose test matrix through /testing folder #25393

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

dwarakaprasad
Copy link
Contributor

@dwarakaprasad dwarakaprasad commented Mar 3, 2024

fixes #25384

With this change, blueprints will have access to test/support i.e. matrix.

usage:
import { clientSamples, buildClientSamples, buildServerMatrix } from 'generator-jhipster/testing';


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@dwarakaprasad dwarakaprasad marked this pull request as ready for review March 5, 2024 20:31
@DanielFran DanielFran requested a review from mshima March 6, 2024 08:45
@mshima
Copy link
Member

mshima commented Mar 6, 2024

Please move exported methods to testing.
So we have a clear distinction of libs that should be stable during major cycle.
Test folder is not stable.

@dwarakaprasad
Copy link
Contributor Author

Majority of the changes are related to testHelpers* that are imported through test/support/index.js (which was exporting ../testing/helpers.js). I have refactored this to import from testing/index.js.

@mshima
Copy link
Member

mshima commented Mar 8, 2024

Thanks @dwarakaprasad

@mshima mshima merged commit 3e27d31 into jhipster:main Mar 8, 2024
52 checks passed
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment