-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust blueprint generator scheduling #25445
Conversation
This indeed is the correct behavior for full blueprints, but will break sbs blueprints. The And add the conditional function before:
|
Thank you for your insight! please correct me if i am wrong.
As is today,
Expectation is,
Instead of only having a binary possibility, you are proposing to have a function that will let generators make sophisticated decisions. Since this proposal needs change to yeoman-environment, both releases will have to be timed. |
Yes, that's it. The only part that is not correct is:
The blueprinted generator's tasks are not queue unless the full blueprint inherits its tasks. The blueprinted generator is
Should be:
No problem with that. |
Yes, it makes sense.
Yes... |
* add call back function support to deceide generator scheduling requiredby jhipster/generator-jhipster#25445 * incorporate review suggestions
…uling (#6) * add call back function support to deceide generator scheduling requiredby jhipster/generator-jhipster#25445 * incorporate review suggestions
fixes #25444
A full blueprint (sbsBlueprint - false) will schedule immediately i.e. replacing the queue slot of the blueprinted generator.
A sbs blueprint (sbsBlueprint - true) will not affect the blueprinted generator's slot in queue but will take its own slot down below it.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.