Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Keycloak 25.0.0 #26420

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Upgrade to Keycloak 25.0.0 #26420

merged 1 commit into from
Jun 20, 2024

Conversation

qmonmert
Copy link
Contributor

Fix #26398


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert marked this pull request as ready for review June 12, 2024 19:26
@mraible
Copy link
Contributor

mraible commented Jun 12, 2024

The Kubernetes generator probably needs updates for Keycloak too.

@mraible
Copy link
Contributor

mraible commented Jun 20, 2024

@qmonmert Do we need to specify the management port in this file or do you think it's OK as-is?

@qmonmert
Copy link
Contributor Author

@mraible I am not a specialist of Kubernetes so I don't know

@mraible
Copy link
Contributor

mraible commented Jun 20, 2024

@qmonmert After looking closer, I don't believe it needs to change since port 9000 is the default management port and that shouldn't be used in a production environment, unlike development and npm start.

@mraible mraible merged commit 469e214 into jhipster:main Jun 20, 2024
52 checks passed
@mraible mraible changed the title Upgrade Keycloak 25.0.0 Upgrade to Keycloak 25.0.0 Jun 20, 2024
@mraible mraible added this to the 8.6.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants