Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typechecking on client generator #27134

Closed
wants to merge 1 commit into from

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Aug 31, 2024

Second try for #27097
contribute to #26114

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl
Copy link
Contributor Author

Tcharl commented Sep 3, 2024

Please give more comment or accept: I'm not pushing complete change at once by fear of conflicts or monster reviews. Every pr contributes to an objective and is incremental

@mshima
Copy link
Member

mshima commented Sep 3, 2024

@Tcharl see #27152, this is caused by circular dependency.
So JDL should be completely independent.
For example we should use generic:

Entity A
search A with current (or any)

instead of:

Entity A
search A with elasticsearch (or couchbase)

@Tcharl
Copy link
Contributor Author

Tcharl commented Sep 3, 2024

So let's fix that glitch.
Leaf gen should point to a base gen (look to be the case, respect!), specific jdl dsl should point to an aggregator (convert/export).
State machine is the core (generator tasks) iterates over contributions (generators implementation). Jdl is like a cli, thus at the early steps of the lifecycle.
To me

  • Definition is at the root (object), can be modularized
  • command and jdl feed the instances
  • generator templates consumes instances.

There shouldn't be any technological circular dependency but the ones between generators if they are not well designed

@mshima
Copy link
Member

mshima commented Sep 8, 2024

@Tcharl with #27203 configs added to command.configs will automatically appear on jhipsterConfig and jhipsterConfigWithDefaults.

@Tcharl Tcharl marked this pull request as draft September 10, 2024 17:22
@Tcharl Tcharl closed this Sep 14, 2024
@mraible mraible added this to the 8.7.1 milestone Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants