Upgrade eslint-plugin-import-x 4.2.1 #27186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
theme: dependencies
DanielFran
approved these changes
Sep 5, 2024
mshima
reviewed
Sep 5, 2024
| @@ -64,7 +64,7 @@ export default ts.config( | |||
| }, | |||
| }, | |||
| { | |||
| files: ['bin/**/*', '**/*.spec.ts', 'testing/**/*', 'test/**/*'], | |||
| files: ['generators/**/*', 'bin/**/*', 'cli/**/*', '**/*.spec.ts', 'testing/**/*', 'test/**/*'], | |||
There was a problem hiding this comment.
This looks a bug in import-x plugin.
bin/*.spec.ts/test files are not exported so we should ignore.
testing folder uses dependencies from peerDependencies so its not resolved from dependencies.
I think we should ignore yeoman-generator/yeoman-environment using https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-unresolved.md#ignore instead
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27178
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.