generated java tests now passes with unique validation #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks if a required entity is already created in the createEntity method, adds the creatUpdatedEntity using the UPDATED_ constants and adds the findAll method to TestUtils. Fix jhipster#9666
| /** | ||
| * Create an entity for this test. | ||
| * Create an <% if (fieldStatus === 'UPDATED_') { %>updated<% } %> entity for this test. |
There was a problem hiding this comment.
Should be: Create an <% if (fieldStatus === 'UPDATED_') { %>updated <% } %>entity for this test.
Otherwise, we can have: * Create an entity for this test., with 2 spaces between an and entity
| * @param <T> The type of objects to be searched | ||
| * @param em The instance of the EntityManager | ||
| * @param clss The class type to be searched | ||
| * @return A list of all found objects of the |
There was a problem hiding this comment.
A list of all found objects of the -> A list of all found objects
| /** | ||
| * Create an entity for this test. | ||
| * Create an <% if (fieldStatus === 'UPDATED_') { %>updated<% } %>entity for this test. |
There was a problem hiding this comment.
ahh still missing 1 space: %>updated <%
There was a problem hiding this comment.
Just fixed directly in your branch
|
thanks for your fix @Gabrui ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if a required entity is already created in the createEntity method,
adds the creatUpdatedEntity using the UPDATED_ constants and
adds the findAll method to TestUtils.
Fix #9666
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed